From: Igor Zlatkovic (igorz@dialup.nacamar.de)
Date: Thu Jan 25 2001 - 07:38:22 EST
Alejo, everyone, sorry. Forgive me. Forget about the thing below. I payed no
attention to the rest of the functions being patched. In fact, a blind bat
would see that path cannot be NULL at the time xmlCheckFilename is called.
Five negative points for me.
Igor
-----
Just one more small issue. Here are few lines from your patch:
@@ -264,8 +326,9 @@
path = &filename[8];
else
path = filename;
- if (path == NULL)
- return(NULL);
+
+ if (!xmlCheckFilename(path))
+ return(NULL);
This means, you remove the statement which checks path against NULL and add
a call to xmlCheckFilename in its stead, passing it path as a parameter.
Indeed, if the path is NULL and we have stat(2), xmlCheckFilename calls
stat(2) internally, passing on the NULL. Who guarantees that stat(2) would
accept NULL and live?
Just incase someone is interrested, _stat from Win32 C-runtime does not
survive NULL as a parameter. It trashes. Therefore, I would suggest to leave
the check for NULL in place and simply add your a call to xmlCheckFilename
after that.
---- Message from the list xml@rpmfind.net Archived at : http://xmlsoft.org/messages/ to unsubscribe: echo "unsubscribe xml" | mail majordomo@rpmfind.net
This archive was generated by hypermail 2b29 : Thu Jan 25 2001 - 08:45:43 EST