Re: [xml] Bugs in copying parts of tree.c

Date view Thread view Subject view Author view

From: Daniel Veillard (Daniel.Veillard@imag.fr)
Date: Wed Jan 31 2001 - 10:49:15 EST


On Wed, Jan 31, 2001 at 04:23:04PM +0100, Anders Karlsson wrote:
> I have now digged deeper into the libxml code and found two bugs in the
> implementation om xmlCopyDoc.
>
> Bug 1: Missing 'charset' copy in xmlCopyDoc
> -------------------------------------------
> This should be fixed by adding the following line:
>
> ret->charset = doc->charset;

  Right,

> Bug 2: Casting problems in xmlCopyDoc
> -------------------------------------
[...]
> This can be solved by checking the type when copying the nodes in
> xmlStaticCopyNodeList and if it is a DTD node it should be copied with
> xmlCopyDtd instead:

  Right too,

> diff -ur libxml2-2.2.12/tree.c libxml2-2.2.12-new/tree.c

  Will apply,

    thanks for the analysis and the patch,

Daniel

-- 
Daniel Veillard      | Red Hat Network http://redhat.com/products/network/
veillard@redhat.com  | libxml Gnome XML toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
----
Message from the list xml@rpmfind.net
Archived at : http://xmlsoft.org/messages/
to unsubscribe: echo "unsubscribe xml" | mail  majordomo@rpmfind.net


Date view Thread view Subject view Author view

This archive was generated by hypermail 2b29 : Wed Jan 31 2001 - 12:50:30 EST