From: Igor Zlatkovic (igorz@dialup.nacamar.de)
Date: Thu Jan 25 2001 - 07:24:58 EST
Hello.
Alejo, you almost did it. The work looks good, just few things more need be
done before it would work under Win32.
OK, since you have no way of knowing, let me tell you: GNU autoconf anf GNU
automake have no significance under Win32. They produce a sh script which
cannot be executed in vanilla Win32 environment because Win32 lacks a
bourne/korn shell. Therefore, there is no effect in modifying config.in.
Instead, you must edit the include/win32config.h file and add
#define HAVE_SYS_STAT_H
#define HAVE__STAT
somewhere near the beginning. The first macro shall cause the file
sys/stat.h to be included in xmlIO.c, while the second enables your macros
in xmlIO.c which define S_ISFDIR.
Just one more small issue. Here are few lines from your patch:
@@ -264,8 +326,9 @@
path = &filename[8];
else
path = filename;
- if (path == NULL)
- return(NULL);
+
+ if (!xmlCheckFilename(path))
+ return(NULL);
This means, you remove the statement which checks path against NULL and add
a call to xmlCheckFilename in its stead, passing it path as a parameter.
Indeed, if the path is NULL and we have stat(2), xmlCheckFilename calls
stat(2) internally, passing on the NULL. Who guarantees that stat(2) would
accept NULL and live?
Just incase someone is interrested, _stat from Win32 C-runtime does not
survive NULL as a parameter. It trashes. Therefore, I would suggest to leave
the check for NULL in place and simply add your a call to xmlCheckFilename
after that.
That would be all. I see no other problems.
Ciao
Igor
---- Message from the list xml@rpmfind.net Archived at : http://xmlsoft.org/messages/ to unsubscribe: echo "unsubscribe xml" | mail majordomo@rpmfind.net
This archive was generated by hypermail 2b29 : Thu Jan 25 2001 - 08:45:43 EST